Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

As part of the move to externalize ImageSharp.Drawing and import Core I thought it wise to simplify and normalize our use of #ifdefs throughout the library.

Once we have a CI build environment that works on .NET Core 3.1 we can easily add additional target frameworks.

Touch #1002

@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #1075 into master will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1075      +/-   ##
==========================================
+ Coverage   89.95%   89.95%   +<.01%     
==========================================
  Files        1200     1200              
  Lines       53013    53010       -3     
  Branches     3847     3847              
==========================================
- Hits        47689    47687       -2     
+ Misses       4556     4555       -1     
  Partials      768      768
Impacted Files Coverage Δ
src/ImageSharp/Formats/Bmp/BmpDecoderCore.cs 94.38% <ø> (ø) ⬆️
src/ImageSharp/Formats/Bmp/BmpEncoderCore.cs 95.33% <ø> (ø) ⬆️
src/ImageSharp/Formats/Tga/TgaDecoderCore.cs 88.1% <ø> (ø) ⬆️
src/ImageSharp/Formats/Gif/LzwDecoder.cs 92.94% <ø> (ø) ⬆️
src/ImageSharp/Formats/Tga/TgaEncoderCore.cs 98.51% <ø> (ø) ⬆️
...c/ImageSharp/Common/Extensions/StreamExtensions.cs 93.33% <75%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06bf7ac...b8306a3. Read the comment docs.

@JimBobSquarePants
Copy link
Member Author

Imma gonna go ahead with this now I've consolidated the build constants. I want to move on to #1076

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after a quick review on mobile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants