Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Jan 28, 2020

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

  • Exposes the various IPixel operations as bulk operations. Individual overriding classes remain internal.
  • Normalize Configuration usage and expose GetConfiguration() extension for ImageFrame
  • Normalize MemoryAllocator usage and expose only via Configuration.

Fix #1092

@JimBobSquarePants JimBobSquarePants added this to the 1.0.0-rc1 milestone Jan 28, 2020
@JimBobSquarePants JimBobSquarePants requested a review from a team January 28, 2020 03:40
@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #1095 into master will increase coverage by <.01%.
The diff coverage is 97.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1095      +/-   ##
==========================================
+ Coverage   81.49%   81.49%   +<.01%     
==========================================
  Files         704      704              
  Lines       29381    29389       +8     
  Branches     3289     3290       +1     
==========================================
+ Hits        23944    23951       +7     
  Misses       4745     4745              
- Partials      692      693       +1
Flag Coverage Δ
#unittests 81.49% <97.71%> (ø) ⬆️
Impacted Files Coverage Δ
src/ImageSharp/Configuration.cs 100% <ø> (ø) ⬆️
src/ImageSharp/Image{TPixel}.cs 90% <100%> (ø) ⬆️
...rocessors/Quantization/WuFrameQuantizer{TPixel}.cs 91.79% <100%> (ø) ⬆️
...ssors/Overlays/BackgroundColorProcessor{TPixel}.cs 100% <100%> (ø) ⬆️
...sors/Quantization/PaletteFrameQuantizer{TPixel}.cs 100% <100%> (ø) ⬆️
...ntations/Generated/L8.PixelOperations.Generated.cs 100% <100%> (ø) ⬆️
...ations/Generated/La16.PixelOperations.Generated.cs 98.16% <100%> (ø) ⬆️
...ats/PixelImplementations/Rgba32.PixelOperations.cs 100% <100%> (ø) ⬆️
...tions/Generated/Rgb48.PixelOperations.Generated.cs 100% <100%> (ø) ⬆️
...PixelImplementations/RgbaVector.PixelOperations.cs 100% <100%> (ø) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966dd46...6c4050f. Read the comment docs.

@JimBobSquarePants JimBobSquarePants changed the title Expose operations. Fix #1092 Expose Pixel Operations and Configuration Jan 28, 2020
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a naming nit, otherwise LGTM.

@JimBobSquarePants JimBobSquarePants merged commit 71547c4 into master Jan 28, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/expose-pixel-operations branch January 28, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

expose ToRgba64 + add GetConfiguration to image frame

2 participants