Change ImageFormatException to InvalidImageContentException #1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1190 +/- ##
==========================================
- Coverage 82.55% 82.54% -0.01%
==========================================
Files 692 692
Lines 29976 29986 +10
Branches 3388 3388
==========================================
+ Hits 24746 24752 +6
- Misses 4533 4537 +4
Partials 697 697
Continue to review full report at Codecov.
|
| // TODO: use InvalidImageContentException here, if we decide to define it | ||
| // https://github.com/SixLabors/ImageSharp/issues/1110 | ||
| throw new ImageFormatException($"Can not decode image. Failed to allocate buffers for possibly degenerate dimensions: {dims.Width}x{dims.Height}. This error can happen for very large RLE bitmaps, which are not supported.", ex); | ||
| throw new InvalidImageContentException($"Can not decode image. Failed to allocate buffers for possibly degenerate dimensions: {dims.Width}x{dims.Height}. This error can happen for very large RLE bitmaps, which are not supported.", ex); |
There was a problem hiding this comment.
Can you move these and others to the ThrowHelper classes for each format please. That's why I missed them.
brianpopow
commented
Apr 28, 2020
| GifThrowHelper.ThrowInvalidImageContentException($"Can not decode image. Failed to allocate buffers for possibly degenerate dimensions: {dims.Width}x{dims.Height}.", ex); | ||
|
|
||
| // Not reachable, as the previous statement will throw a exception. | ||
| return null; |
There was a problem hiding this comment.
@JimBobSquarePants is there a way to annotate a method, that it will always throw to avoid this return statement?
There was a problem hiding this comment.
Unfortunately not. There's something coming in NET5 I believe but it won't be backwards compatible.
JimBobSquarePants
approved these changes
Apr 28, 2020
This was referenced Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Change a few exceptions to
InvalidImageContentExceptionwhich were missed in #1179