Skip to content

Conversation

@brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This fixes an issue with very large jpeg images. For example: This

I have not added a test image, because i dont want such super large test files in the repo. Im not sure how we can properly test it without it.

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s difficult to test but I doubt anyone will ever make a change to that section without good reason

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #1197 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1197   +/-   ##
=======================================
  Coverage   82.58%   82.58%           
=======================================
  Files         694      694           
  Lines       30046    30046           
  Branches     3397     3397           
=======================================
  Hits        24813    24813           
  Misses       4535     4535           
  Partials      698      698           
Flag Coverage Δ
#unittests 82.58% <100.00%> (ø)
Impacted Files Coverage Δ
...Sharp/Formats/Jpeg/Components/Decoder/JpegFrame.cs 95.83% <100.00%> (ø)
src/ImageSharp/Formats/Jpeg/JpegDecoderCore.cs 92.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b44008e...9415e58. Read the comment docs.

@brianpopow brianpopow merged commit de74ad4 into master May 8, 2020
@brianpopow brianpopow deleted the fixForVeryLargeJpg branch May 8, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants