Ensure min dimension of 1px following rounding. #1198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1198 +/- ##
=======================================
Coverage 82.58% 82.58%
=======================================
Files 694 694
Lines 30046 30047 +1
Branches 3397 3397
=======================================
+ Hits 24813 24814 +1
Misses 4535 4535
Partials 698 698
Continue to review full report at Codecov.
|
dlemstra
reviewed
May 9, 2020
|
|
||
| private static void ThrowInvalid(string message) => throw new InvalidOperationException(message); | ||
|
|
||
| private static int Sanitize(int input) |
There was a problem hiding this comment.
Nitpicking but this could be an arrow.
There was a problem hiding this comment.
I'm usually not precious, updated now though
dlemstra
reviewed
May 9, 2020
src/ImageSharp/Processing/Processors/Transforms/Resize/ResizeHelper.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 30, 2025
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
When calculating a target size/rectangle during resizing ensure that rounding doesn't leave a width/height of zero. Fixes #1195