- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 888
Use ConcurrentDictionary for options properties. #1234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Codecov Report
 @@            Coverage Diff             @@
##           master    #1234      +/-   ##
==========================================
- Coverage   82.54%   82.54%   -0.01%     
==========================================
  Files         697      697              
  Lines       30512    30511       -1     
  Branches     3469     3469              
==========================================
- Hits        25187    25186       -1     
  Misses       4605     4605              
  Partials      720      720              
 
 Continue to review full report at Codecov. 
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Prerequisites
Description
Fix #1230 #1224
The two dictionaries used in
ConfigurationandDefaultImageProcessorContextwere not thread safe and would throw when accessed in a parallel context.I've replaced them with
ConcurrentDictionaryinstances which fixes the issue but I wonder whether we should be exposing the property asIDictionary<object, object>over the concrete type since we require thread safety.