Skip to content

Conversation

@brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

As the title says: The guard of the position was a bit too strict.

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #1291 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1291   +/-   ##
=======================================
  Coverage   82.70%   82.70%           
=======================================
  Files         697      697           
  Lines       30677    30677           
  Branches     3470     3470           
=======================================
  Hits        25370    25370           
  Misses       4604     4604           
  Partials      703      703           
Flag Coverage Δ
#unittests 82.70% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ImageSharp/IO/BufferedReadStream.cs 92.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 493e422...5c6b6c7. Read the comment docs.

@JimBobSquarePants JimBobSquarePants added this to the 1.0.0 milestone Jul 27, 2020
@JimBobSquarePants JimBobSquarePants merged commit f4f689c into master Jul 27, 2020
@JimBobSquarePants JimBobSquarePants deleted the bp/bufferStreamGuard branch July 27, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants