Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Increase ChunkedMemoryStream chunk length to 128k inline with RecycledMemoryStream

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (DefaultBufferLength change)

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #1328 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1328   +/-   ##
=======================================
  Coverage   82.74%   82.75%           
=======================================
  Files         689      689           
  Lines       30933    30938    +5     
  Branches     3508     3508           
=======================================
+ Hits        25597    25602    +5     
  Misses       4617     4617           
  Partials      719      719           
Flag Coverage Δ
#unittests 82.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ImageSharp/IO/ChunkedMemoryStream.cs 81.11% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d95a996...ff265ab. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit 801961d into master Aug 25, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/chunk-bump branch August 25, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants