Skip to content

Fix missing SDK version for test building it GitHub Workflow #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix missing SDK version for test building it GitHub Workflow #1329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86c9c33
Fix missing SDK version for test
Turnerj Aug 25, 2020
a66981a
Avoid SDK requirements for non-tested projects
Turnerj Aug 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,27 @@ jobs:
framework: netcoreapp3.1
runtime: -x64
codecov: false
sdkVersion: "3.1.x"
- os: windows-latest
framework: netcoreapp3.1
runtime: -x64
codecov: true
sdkVersion: "3.1.x"
- os: windows-latest
framework: netcoreapp2.1
runtime: -x64
codecov: false
sdkVersion: "2.1.x"
- os: windows-latest
framework: net472
runtime: -x64
codecov: false
sdkVersion: "3.1.x"
- os: windows-latest
framework: net472
runtime: -x86
codecov: false
sdkVersion: "3.1.x"

runs-on: ${{matrix.options.os}}
if: "!contains(github.event.head_commit.message, '[skip ci]')"
Expand All @@ -55,7 +60,7 @@ jobs:
- name: Setup DotNet SDK
uses: actions/setup-dotnet@v1
with:
dotnet-version: "3.1.x"
dotnet-version: ${{matrix.options.sdkVersion}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't figure out from the docs whether you can simply do. [ "2.1.x", "3.1.x" ]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Digging through the TypeScript code for the action, it looks to only take string values. Internally, the value is getting passed into here: https://github.com/actions/setup-dotnet/blob/e3d81d94533f1e31c11d94a1fdf6f60f096a7bc5/src/installer.ts#L33

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, ran a quick test in the Web repo. Big fail


- name: Build
shell: pwsh
Expand Down
2 changes: 1 addition & 1 deletion ci-build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ dotnet clean -c Release
$repositoryUrl = "https://github.com/$env:GITHUB_REPOSITORY"

# Building for a specific framework.
dotnet build -c Release -f $targetFramework /p:RepositoryUrl=$repositoryUrl
dotnet build tests/ImageSharp.Tests/ImageSharp.Tests.csproj -c Release -f $targetFramework /p:RepositoryUrl=$repositoryUrl