Skip to content

Conversation

@Sergio0694
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR does two things:

  • Adds missing input validation for the blur radius and number of components (with tests)
  • Reduces the overhead of the default constructor and skips the input validation there

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonfirsov antonfirsov merged commit 9b9e134 into master Aug 31, 2020
@antonfirsov antonfirsov deleted the sp/bokeh-blur-init-tweaks branch August 31, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants