-
-
Notifications
You must be signed in to change notification settings - Fork 888
Auto repair Png options to use Bit8. #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1395 +/- ##
==========================================
+ Coverage 82.87% 82.88% +0.01%
==========================================
Files 690 690
Lines 30903 30903
Branches 3545 3544 -1
==========================================
+ Hits 25610 25614 +4
+ Misses 4572 4570 -2
+ Partials 721 719 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Auto repair Png options to use Bit8.
Prerequisites
Description
Fixes #935
Rather than throwing when ColorType/BitDepth options are passed that are not supported by the PNG specification we can use
PngBitDepth.Bit8to fix up the options.This bit depth is the only one supported by all color type values.