Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Oct 29, 2020

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Saw someone complaining on Discord about this so fixed it.

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #1407 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1407   +/-   ##
=======================================
  Coverage   82.99%   82.99%           
=======================================
  Files         692      692           
  Lines       31189    31189           
  Branches     3578     3578           
=======================================
  Hits        25884    25884           
  Misses       4582     4582           
  Partials      723      723           
Flag Coverage Δ
#unittests 82.99% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ImageSharp/Image{TPixel}.cs 92.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f015e...8464a3d. Read the comment docs.

Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great to see that LINQ path gone 😄🚀

@JimBobSquarePants JimBobSquarePants merged commit adf56a4 into master Oct 29, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/TryGetSinglePixelSpan branch October 29, 2020 16:20
JimBobSquarePants added a commit that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants