-
-
Notifications
You must be signed in to change notification settings - Fork 888
Enable resize tests on MacOs #1434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Differences seem to be tolerable. I thought these will be the 20% failures, looks they are gone, but no idea how. |
|
Before I add tolerance to the comparer on macOS. I'll just try swapping all floats for double in |
Codecov Report
@@ Coverage Diff @@
## master #1434 +/- ##
=======================================
Coverage 83.63% 83.63%
=======================================
Files 733 733
Lines 31919 31919
Branches 3590 3590
=======================================
Hits 26697 26697
Misses 4508 4508
Partials 714 714
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Just ended up bumping the tolerance on OSX + CI as the tests are passing locally. |
Enable resize tests on MacOs
Prerequisites
Description
The 3 resize tests skipped on macOS are working on my machine. I'm opening this to see what is happening on CI.