Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

The 3 resize tests skipped on macOS are working on my machine. I'm opening this to see what is happening on CI.

@antonfirsov
Copy link
Member

Differences seem to be tolerable. I thought these will be the 20% failures, looks they are gone, but no idea how.

@JimBobSquarePants
Copy link
Member Author

Before I add tolerance to the comparer on macOS. I'll just try swapping all floats for double in ResizeHelper.CalculateTargetLocationAndBounds. Looking at the errors they seem to be leading edges

@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #1434 (ecf05e2) into master (a9e2b4c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1434   +/-   ##
=======================================
  Coverage   83.63%   83.63%           
=======================================
  Files         733      733           
  Lines       31919    31919           
  Branches     3590     3590           
=======================================
  Hits        26697    26697           
  Misses       4508     4508           
  Partials      714      714           
Flag Coverage Δ
unittests 83.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9e2b4c...ecf05e2. Read the comment docs.

@JimBobSquarePants
Copy link
Member Author

Just ended up bumping the tolerance on OSX + CI as the tests are passing locally.

@JimBobSquarePants JimBobSquarePants requested a review from a team November 21, 2020 01:03
@JimBobSquarePants JimBobSquarePants merged commit 9b7df13 into master Nov 22, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/macos-enable-tests branch November 22, 2020 17:01
JimBobSquarePants added a commit that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants