Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #1530

The provided test image contains descriptor information that generates a restore rectangle lager than the frame dimensions. The fix limits the maximum bounds to the frame dimensions.

@JimBobSquarePants JimBobSquarePants added this to the 1.1.0 milestone Feb 2, 2021
@JimBobSquarePants JimBobSquarePants requested a review from a team February 2, 2021 17:29
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #1532 (ba115e1) into master (7dfea13) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1532      +/-   ##
==========================================
+ Coverage   83.50%   83.52%   +0.01%     
==========================================
  Files         742      742              
  Lines       32801    32802       +1     
  Branches     3671     3671              
==========================================
+ Hits        27392    27399       +7     
+ Misses       4691     4689       -2     
+ Partials      718      714       -4     
Flag Coverage Δ
unittests 83.52% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ImageSharp/Formats/Gif/GifDecoderCore.cs 86.58% <100.00%> (+2.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dfea13...ba115e1. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit edff37d into master Feb 2, 2021
@JimBobSquarePants JimBobSquarePants deleted the js/fix-1530 branch February 2, 2021 18:00
JimBobSquarePants added a commit that referenced this pull request Mar 13, 2021
Sanitize Gif descriptor bounds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

load gif System.ThrowHelper.ThrowArgumentOutOfRangeException(ExceptionArgument argument)

2 participants