Limit ancillary PNG chunk size. #2681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.header.Height, | ||
| metadata); | ||
| } | ||
| image = new Image<TPixel>(this.configuration, this.header.Width, this.header.Height, metadata); |
There was a problem hiding this comment.
The optimization was causing more trouble than it was worth. Any PNGs with invalid data yielded non-deterministic results.
tocsoft
approved these changes
Mar 1, 2024
This was referenced Jul 30, 2025
This was referenced Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Adds a configurable value limiting the size of uncompressed buffers in ancillary PNG chunks.