-
-
Couldn't load subscription status.
- Fork 888
V3 - Use BPP from Color Writer for Compressor #2915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the TIFF compressor initialization to use the computed BitsPerPixel from the color writer, ensuring parity between the compressor and the color writer. Key changes include:
- Defining a new test image constant for Issue2909.
- Adding new test cases for LZW and Deflate compression using the Issue2909 file.
- Updating the TiffEncoderCore to obtain BitsPerPixel from the color writer instead of from the encoder instance.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/ImageSharp.Tests/TestImages.cs | Added constant for Issue2909 test image. |
| tests/ImageSharp.Tests/Formats/Tiff/TiffEncoderTests.cs | Added test cases for LZW and Deflate compression using Issue2909. |
| src/ImageSharp/Formats/Tiff/TiffEncoderCore.cs | Changed compressor initialization to use colorWriter.BitsPerPixel. |
Files not reviewed (1)
- tests/Images/Input/Tiff/Issues/Issue2909.tiff: Language not supported
Prerequisites
Description
Uses the computed
BitsPerPixelfrom the color writer instance for the compressor to ensure parity.Fixes #2909