-
-
Notifications
You must be signed in to change notification settings - Fork 888
Respecting fileHeader Offset, skipping bytes if necessary #819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respecting fileHeader Offset, skipping bytes if necessary #819
Conversation
Codecov Report
@@ Coverage Diff @@
## master #819 +/- ##
==========================================
+ Coverage 88.65% 88.74% +0.08%
==========================================
Files 1015 1015
Lines 44120 44130 +10
Branches 3178 3180 +2
==========================================
+ Hits 39116 39164 +48
+ Misses 4241 4237 -4
+ Partials 763 729 -34
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #819 +/- ##
=========================================
- Coverage 88.8% 88.8% -0.01%
=========================================
Files 1015 1015
Lines 44138 44148 +10
Branches 3178 3180 +2
=========================================
+ Hits 39198 39206 +8
- Misses 4211 4212 +1
- Partials 729 730 +1
Continue to review full report at Codecov.
|
|
@brianpopow Again amazing work, you rock! 👍 |
Prerequisites
Description
The file header offset is ignored, which indicates where the image data starts. This can cause incorrectly decoded images.
This PR changes this and unused bytes between the palette and the image will be skipped.