Skip to content

Conversation

@brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

The file header offset is ignored, which indicates where the image data starts. This can cause incorrectly decoded images.

This PR changes this and unused bytes between the palette and the image will be skipped.

@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

Merging #819 into master will increase coverage by 0.08%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #819      +/-   ##
==========================================
+ Coverage   88.65%   88.74%   +0.08%     
==========================================
  Files        1015     1015              
  Lines       44120    44130      +10     
  Branches     3178     3180       +2     
==========================================
+ Hits        39116    39164      +48     
+ Misses       4241     4237       -4     
+ Partials      763      729      -34
Impacted Files Coverage Δ
tests/ImageSharp.Tests/TestImages.cs 100% <ø> (ø) ⬆️
...ts/ImageSharp.Tests/Formats/Bmp/BmpDecoderTests.cs 98.92% <100%> (+0.06%) ⬆️
src/ImageSharp/Formats/Bmp/BmpDecoderCore.cs 83.21% <60%> (+0.19%) ⬆️
...files/ICC/DataWriter/IccDataWriter.TagDataEntry.cs 77.14% <0%> (ø) ⬆️
src/ImageSharp/Processing/ResizeHelper.cs 42.42% <0%> (ø) ⬆️
...ils/ReferenceImplementations.StandardIntegerDCT.cs 93.68% <0%> (ø) ⬆️
src/ImageSharp/Formats/Png/PngEncoderCore.cs 93.51% <0%> (+0.27%) ⬆️
...files/ICC/DataReader/IccDataReader.TagDataEntry.cs 85.91% <0%> (+0.28%) ⬆️
...harp.Tests/Drawing/FillLinearGradientBrushTests.cs 99.5% <0%> (+0.49%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2849fd9...5986687. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

Merging #819 into master will decrease coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #819      +/-   ##
=========================================
- Coverage    88.8%   88.8%   -0.01%     
=========================================
  Files        1015    1015              
  Lines       44138   44148      +10     
  Branches     3178    3180       +2     
=========================================
+ Hits        39198   39206       +8     
- Misses       4211    4212       +1     
- Partials      729     730       +1
Impacted Files Coverage Δ
tests/ImageSharp.Tests/TestImages.cs 100% <ø> (ø) ⬆️
...ts/ImageSharp.Tests/Formats/Bmp/BmpDecoderTests.cs 98.92% <100%> (+0.06%) ⬆️
src/ImageSharp/Formats/Bmp/BmpDecoderCore.cs 83.21% <60%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a60638...c454447. Read the comment docs.

@JimBobSquarePants
Copy link
Member

@brianpopow Again amazing work, you rock! 👍

@JimBobSquarePants JimBobSquarePants merged commit 637f767 into SixLabors:master Feb 5, 2019
antonfirsov pushed a commit to antonfirsov/ImageSharp that referenced this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants