-
-
Notifications
You must be signed in to change notification settings - Fork 888
GDI+ stability fixes for the benchmark and tests #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…table, this should hopefully prevent "a generic error occurred in GDI+". Hopefully I didn't miss one...
|
@Lakritzator Ah this is great! 👍 |
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
==========================================
+ Coverage 88.84% 88.84% +<.01%
==========================================
Files 1015 1015
Lines 44167 44169 +2
Branches 3181 3181
==========================================
+ Hits 39241 39243 +2
Misses 4201 4201
Partials 725 725
Continue to review full report at Codecov.
|
|
I'm not sure how reproducible the problems were, but I guess I didn't make it worse. Just let me know when you see the issue again, and I will have a more thorough look! But my gut feeling tells me I got all... |
|
P.S. I like the automation you did, I really should use this CLAassistant too... |
Prerequisites
Description
Some changes to make the usages of GDI in benchmarks and tests more stable, this should hopefully prevent "a generic error occurred in GDI+". Hopefully I didn't miss one...
If you new Pen, Brush or Fonts, these need to be disposed.