Skip to content

Conversation

@Lakritzator
Copy link
Contributor

@Lakritzator Lakritzator commented Feb 15, 2019

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Some changes to make the usages of GDI in benchmarks and tests more stable, this should hopefully prevent "a generic error occurred in GDI+". Hopefully I didn't miss one...

If you new Pen, Brush or Fonts, these need to be disposed.

…table, this should hopefully prevent "a generic error occurred in GDI+". Hopefully I didn't miss one...
@CLAassistant
Copy link

CLAassistant commented Feb 15, 2019

CLA assistant check
All committers have signed the CLA.

@JimBobSquarePants
Copy link
Member

@Lakritzator Ah this is great! 👍

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #835 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
+ Coverage   88.84%   88.84%   +<.01%     
==========================================
  Files        1015     1015              
  Lines       44167    44169       +2     
  Branches     3181     3181              
==========================================
+ Hits        39241    39243       +2     
  Misses       4201     4201              
  Partials      725      725
Impacted Files Coverage Δ
...stUtilities/ReferenceCodecs/SystemDrawingBridge.cs 88.73% <100%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0b012...a09ac21. Read the comment docs.

@Lakritzator
Copy link
Contributor Author

I'm not sure how reproducible the problems were, but I guess I didn't make it worse. Just let me know when you see the issue again, and I will have a more thorough look! But my gut feeling tells me I got all...

@Lakritzator
Copy link
Contributor Author

P.S. I like the automation you did, I really should use this CLAassistant too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants