-
Notifications
You must be signed in to change notification settings - Fork 18
c++11 building support #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: wangbaiping <[email protected]>
|
So, we will have c++11 and c++17 in support at the same time? |
yep. |
|
Could you add a CI for C++11 build and update the doc to mention 11 and 17 supported? |
|
In fact it's build by c++11 by default for now because I remove the explicit option of |
|
/wait |
|
some warnings need to be resolved. |
Signed-off-by: wangbaiping <[email protected]>
Signed-off-by: wangbaiping <[email protected]>
Signed-off-by: wangbaiping <[email protected]>
|  | ||
|
|
||
| Distributed tracing and monitor SDK in CPP for Apache SkyWalking APM | ||
| Distributed tracing and monitor SDK in CPP for Apache SkyWalking APM. This SDK is compatible with C++ 17, C++ 14, and C++ 11. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: wangbaiping [email protected]
absl::string_view/absl::optional/absl::nullopt/...will be alias ofstd::string_view/std::optional/std::nullopt/...after c++17 by default. So it's ok to always use theabsl::*in c++11/c++14/c++17 versions.