Skip to content

enable to update span's operation name #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2022
Merged

enable to update span's operation name #90

merged 2 commits into from
Mar 22, 2022

Conversation

@Shikugawa
Copy link
Member

@Shikugawa Shikugawa commented Mar 22, 2022

No description provided.

@Shikugawa Shikugawa requested a review from wu-sheng March 22, 2022 12:59
wu-sheng
wu-sheng approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tip, the operation name is relative to the header(sw8), so need to make sure this is changed before injection.

@wu-sheng wu-sheng modified the milestones: 0.3.0, 0.4.0 Mar 22, 2022
@wu-sheng wu-sheng added the enhancement New feature or request label Mar 22, 2022
@wu-sheng wu-sheng merged commit ee2faa3 into main Mar 22, 2022
@wu-sheng wu-sheng deleted the update-opname branch March 22, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

0.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Shikugawa @wu-sheng