Skip to content

Set sub-device peripheralDeviceId from deviceOptions parentDeviceName #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release53
Choose a base branch
from

Conversation

scriptorian
Copy link
Contributor

About the Contributor

This PR has been opened by SuperFly.tv on behalf of EVS Broadcast Equipment (henceforth EVS).

Type of Contribution

This is a:

Feature

Current Behaviour

When configuring a new peripheral sub-device in a Studio upgrade the peripheralDeviceId would be left undefined.

New Behaviour

The updated code allows the device options of the new sub-device to specify a parentDeviceName property that is then used to find a peripheralDeviceId with a matching name.
Parent devices append an extra string to the configured name so the search for a match uses only the first characters of the parent device _id property.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR affects peripheral sub-devices configured through a studio upgrade operation triggered by the API.

Time Frame

We would like to get this merged into the in-development release.

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@scriptorian scriptorian requested a review from a team as a code owner July 31, 2025 12:14
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants