Set sub-device peripheralDeviceId from deviceOptions parentDeviceName #1505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This PR has been opened by SuperFly.tv on behalf of EVS Broadcast Equipment (henceforth EVS).
Type of Contribution
This is a:
Feature
Current Behaviour
When configuring a new peripheral sub-device in a Studio upgrade the peripheralDeviceId would be left undefined.
New Behaviour
The updated code allows the device options of the new sub-device to specify a parentDeviceName property that is then used to find a peripheralDeviceId with a matching name.
Parent devices append an extra string to the configured name so the search for a match uses only the first characters of the parent device _id property.
Testing
Affected areas
This PR affects peripheral sub-devices configured through a studio upgrade operation triggered by the API.
Time Frame
We would like to get this merged into the in-development release.
Status