Support path OR string #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is an updated version of #47 |
|
@Southern You get a chance to look at this? |
|
Heads up that I believe there are some build issues that need resolving on this PR. It usually works, but I have experienced some flakiness when building it as a dependency of a dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm re-opening this PR that @astitt-ripple started. I cleaned up index.js a bit to follow the node conventions.
I took the liberty of polyfilling Promise since it's clear from our .travis.yml that we support Node 0.10.
I also took the liberty of returning the parsed certificate in the verify callback, since we already have that info and it will likely save people some hassle depending on their use case.