Allow multiple packs images #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
|
Rebased to current master, should now be mergeable again :) |
arm4b
suggested changes
Feb 25, 2021
arm4b
reviewed
Feb 25, 2021
| @@ -1,3 +1,8 @@ | |||
| # Notify users about breaking change regarding packs, to not destroy current installations | |||
| {{- if and .Values.st2.packs.image }} | |||
| {{- fail "Value st2.packs.image was renamed to st2.packs.images and is now a list of images" }} | |||
|
Hey @armab |
arm4b
approved these changes
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Maintainers,
this PR adds the option to use multiple st2 packs-images.
This is a breaking change, as value
st2.packs.imageis replaced byst2.packs.images. Datatype changes from dict/hash to list of dicts/hashes.This is useful, when a lot of different packs are being used, as a single container can result in multiple GB very quickly, mostly due to virtualenvs.
When using multiple st2 pack-images, the User can reduce possible downtimes due to reduced image size of new/changed containers. Also the build process can be a lot faster, if the User is providing custom packs.
Currently there is a fail message implemented in
templates/deployments.yamlto prevent Users from accidential removal of their custom st2packs-image. It triggers, whenst2.packs.imageis defined and not empty. This should notify all Users about this change.In #118 & #160 a centralization of packs-specific definitions for this chart was shown. As these PRs are still being discussed for other reasons, I've decided to include these centralizations in this PR.
This should make these PRs a little smaller and more compatible to each other, once they will or will not be finalized.