Skip to content

Conversation

@younesious
Copy link
Contributor

Why I'm doing:

Fixes issue #76 — the routine load quickstart docker-compose.yml fails on macOS because minio_mc cannot connect to the MinIO container due to an incorrect or unavailable healthcheck method.

What I'm doing:

  • Replaced the old healthcheck that used mc ready, which doesn't exist inside minio/minio
  • Added a proper HTTP-based healthcheck using /minio/health/live
  • Adjusted the minio_mc service to wait until mc alias set succeeds

Fixes:

#76

What type of PR is this:

  • BugFix

Does this PR entail a change in behavior?

  • No, this PR will not result in a change in behavior.

Checklist:

  • The modified docker-compose works correctly on macOS
  • The PR improves cross-platform compatibility
  • No core StarRocks logic is changed

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2025

CLA assistant check
All committers have signed the CLA.

@younesious younesious force-pushed the fix/76-minio-healthcheck branch from 3966068 to 0028739 Compare July 11, 2025 16:32
@younesious younesious force-pushed the fix/76-minio-healthcheck branch from 0028739 to 22250f1 Compare July 11, 2025 16:42
@DanRoscigno
Copy link
Contributor

Thanks so much @younesious !

@DanRoscigno DanRoscigno merged commit ef34b2a into StarRocks:master Oct 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants