-
Notifications
You must be signed in to change notification settings - Fork 0
Oauth starmind connector - investigation #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…pt identification
…ed properties for KnowledgeSpace
…dd detailed properties for validation
…operty descriptions
… property descriptions
# Conflicts: # certified-connectors/Starmind/apiDefinition.swagger.json # certified-connectors/Starmind/apiProperties.json
"parameters": { | ||
"token": { | ||
"uiDefinition": { | ||
"constraints": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems required, otherwise the Power Automate UI will fail with a JS error accessing undefined attribute.
The docs should be updated to include this as well
"redirectMode": "GlobalPerConnector", | ||
"customParameters": { | ||
"authorizationUrl": { | ||
"value": "https://auth-staging.starmind.com/auth/realms/1/protocol/openid-connect/auth" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also need to be able to replace "auth-staging.starmind.com" and "1" with corresponding connectionParameters.
We found several examples in the official connector repository that state it should be possible as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
examples
- https://github.com/microsoft/PowerPlatformConnectors/blob/3942660084f1890f0b47e5717d5ab7c632ebbb50/custom-connectors/ServiceNow/apiProperties.json
- https://github.com/microsoft/PowerPlatformConnectors/blob/f181422bebbd068959a3202fdac4b6b64eef3270/certified-connectors/3E%20Events/apiProperties.json#L279
} | ||
} | ||
}, | ||
"token:clientId": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"title": "Apply Starmind API key to Header", | ||
"parameters": { | ||
"x-ms-apimTemplateParameter.name": "Authorization", | ||
"x-ms-apimTemplateParameter.value": "Bearer @connectionParameters('api_key')", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove for the time being since Power Automate will complain about missing api_key connectionParameter in case of OAuth authentication where this parameter is not required.
Please advise how to proceed.
This PR should help to reproduce the multi-auth oauth2 issues we are facing.
apiProperties.json as suggested by the docs: https://learn.microsoft.com/en-us/connectors/custom-connectors/multi-auth#configuration-with-entra-id-and-oauth-20
and as further reference:
With the current example, it is not possible to go through the connection setup flow in power automate. Even if we remove all the ":clientId" that currently prevent us from storing the connection, it would still not run through our OAuth flow but would rather provide our API with the logged in EntraID JWT token. There is no pop up window opening for example.