Skip to content

Conversation

brandmaier
Copy link
Contributor

No description provided.

@Maximilian-Stefan-Ernst Maximilian-Stefan-Ernst changed the base branch from main to devel July 1, 2022 09:40
Copy link
Collaborator

@Maximilian-Stefan-Ernst Maximilian-Stefan-Ernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, we need to

  • write tests
  • add documentation
  • make the use of a meanstructure optional
  • maybe add analytic gradients
  • export the relevant types and methods

@aaronpeikert should we make a feature branch, merge the pull request to that branch and continue there?

@aaronpeikert
Copy link
Collaborator

@aaronpeikert should we make a feature branch, merge the pull request to that branch and continue there?

The only way to rename the source branch is to create a new PR + branch. From my side its ok to treat this as a feature branch though it does not conform to naming guidelines to keep the history (which would be lost in the new PR).

@aaronpeikert
Copy link
Collaborator

Let's merge #135 and #137 then try out the reopening of PRs with #133.

@Maximilian-Stefan-Ernst
Copy link
Collaborator

I dont understand the problem. I can just create a feature/hellinger branch from devel and redirect the pull request there (I already changed it from main to devel).

@aaronpeikert
Copy link
Collaborator

You can change the base but not the source :(

image

@Maximilian-Stefan-Ernst Maximilian-Stefan-Ernst changed the base branch from devel to feature/hellinger July 1, 2022 13:13
@Maximilian-Stefan-Ernst
Copy link
Collaborator

Okay, I changed the base to feature/hellinger, would merge now and continue working on that branch

@aaronpeikert
Copy link
Collaborator

👍

@Maximilian-Stefan-Ernst Maximilian-Stefan-Ernst merged commit c5224e1 into StructuralEquationModels:feature/hellinger Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants