Skip to content

close #151 and add test for it #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2023
Merged

close #151 and add test for it #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
901cd8a
close #151 and add test for it
Maximilian-Stefan-Ernst Aug 7, 2023
4be7cd2
update version and fix fabin 3 starting values
Maximilian-Stefan-Ernst Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "StructuralEquationModels"
uuid = "383ca8c5-e4ff-4104-b0a9-f7b279deed53"
authors = ["Maximilian Ernst", "Aaron Peikert"]
version = "0.2.0"
version = "0.2.1"

[deps]
DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
Expand Down
2 changes: 1 addition & 1 deletion src/additional_functions/start_val/start_fabin3.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ function start_fabin3(ram_matrices::RAMMatrices, Σ, μ)
end

for ram_constant in constants
if (ram_constant.matrix == :A) & (ram_constant.index[2] == i) & (ram_constant.index[1] ∈ F_ind)
if (ram_constant.matrix == :A) && (ram_constant.index[2] == i) && (ram_constant.index[1] ∈ F_ind)
push!(loadings, Symbol(""))
if isone(ram_constant.value)
push!(reference, ram_constant.index[1])
Expand Down
4 changes: 2 additions & 2 deletions src/frontend/specification/RAMMatrices.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ function set_RAMConstant!(A, S, M, rc::RAMConstant)
S[rc.index] = rc.value
S[rc.index[2], rc.index[1]] = rc.value
elseif rc.matrix == :M
M[rd.index] = rc.value
M[rc.index] = rc.value
end
end

Expand Down Expand Up @@ -395,4 +395,4 @@ end

function get_group(d::Dict, group)
return d[group]
end
end
3 changes: 2 additions & 1 deletion test/examples/political_democracy/political_democracy.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ graph = @StenoGraph begin
y8 ↔ y4 + y6
# means
Symbol("1") → _(mean_labels).*_(observed_vars)
Symbol("1") → fixed(0)*ind60
end

spec_mean = ParameterTable(
Expand All @@ -209,4 +210,4 @@ if ENV["JULIA_EXTENDED_TESTS"] == "true"
@testset "Graph → ParameterTable | parts | Optim" begin include("by_parts.jl") end
semoptimizer = SemOptimizerNLopt
@testset "Graph → ParameterTable | parts | NLopt" begin include("by_parts.jl") end
end
end