add ui-bootstrap and materials #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to yeoman generator 0.18 and create bootstrap components optional question rollback to yeoman generator 0.17 as it's not needed anymore and has other impacts handle wiredep bootstrap exclusions with new props first version of material option working first page layout for material reproduce angular material sass for css and less add new options in tests cases add and fix tests
app/index.js
Outdated
Collaborator
There was a problem hiding this comment.
Not neccesary. Instead you can use this._ at https://github.com/Swiip/generator-gulp-angular/pull/137/files#diff-2018087f584c4398b5c3a23fc0e5f9dbR61
zckrs
pushed a commit
that referenced
this pull request
Nov 26, 2014
Add UI-Bootstrap and ngMaterials
|
I like the material design inclusion. Interesting choice. |
Contributor
There was a problem hiding this comment.
I may be wrong, but I think there should be no else as javascript file must be excluded from wiredep when using ui-boostrap or angular-strap. (I'm working on foundation equivalent with angular-foundation).
if(this.props.cssPreprocessor.extension === 'scss') {
this.wiredepExclusions.push('/bootstrap-sass-official/');
}
this.wiredepExclusions.push('/bootstrap.js/');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 new things :