Add angular-foundation support #173
Conversation
There was a problem hiding this comment.
I think else keyword should be removed in order bootstrap.js to be always excluded from wiredep unless using official boostrapComponents.
There was a problem hiding this comment.
wiredep exclusions should be improve to assure that there is no exclusion of something that is not present in the first place. But I think that this was not the case before, so I don't intent you correct it.
Toilal
force-pushed
the
angular-foundation-option
branch
3 times, most recently
from
3e07e2f to
1dad34f
Compare
|
Looks great to me, thanks! 👍 |
|
I just pushed a small fix for unit test to pass, it seems good to me too. thanks |
|
@Swiip I'll make some manual tests in the morning and tell you when all is OK to merge. |
|
I think it's ready for merge. |
Toilal
force-pushed
the
angular-foundation-option
branch
2 times, most recently
from
b14c0d7 to
72509f0
Compare
|
@zckrs I've added tests, thanks for reviewing. |
test/mock-prompts.js
Outdated
There was a problem hiding this comment.
In the default case foundation is not present.
Toilal
force-pushed
the
angular-foundation-option
branch
from
72509f0 to
71101f9
Compare
|
Thanks for you notes @zckrs . I've fix issues mentionned in tests, and also fixed a typo in ngMaterial test https://github.com/Swiip/generator-gulp-angular/blob/master/test/test-gulp-task-inception.mocha.js#L224 |
|
Nice job. Thank you for the contribution. |
|
Thanks ! |
|
Please can you read this guidelines CONTRIBUTING for your next contributions ? |
3 participants
Implements #171