-
Notifications
You must be signed in to change notification settings - Fork 656
Reorganize gulpfiles & gulp tasks #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think dotfiles is gone so this can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right but I think I'll keep this waiting for a further refactoring PR...
This one is too big already
|
It's neat I like the new gulp file templates. |
|
Huge PR but it's awesome
Are you sure _.cloneDeep() create a new object and not use reference in mocha test ? Each test should have a independent prompt |
as in lodash docs. |
Reorganize gulpfiles & gulp tasks
|
👍 Great thanks ! |
This is a big refactoring PR, I'll try to list my goals:
srcfolder, injection target.tmpfolder Modifyindex.htmlin build directory #202 Index.html are empty after error #205scripts.js,styles.jsandmarkups.js, move injection and wiredep ininject.js(Re)organize gulp files #204index.html.tmpfolder to avoid any problems