Skip to content

Conversation

@Swiip
Copy link
Owner

@Swiip Swiip commented Jan 25, 2015

This is my undergoing refactoring of the node source files. My first idea of splitting files by options was not really doable, so I chose something less strict.

I started writing full node unit testing.

It's not finished:

  • Finish writing tests
  • Update method comments.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.54%) to 94.43% when pulling 1406377 on refacto-format into d28665b on master.

@zckrs
Copy link
Collaborator

zckrs commented Jan 26, 2015

👍

@Swiip
Copy link
Owner Author

Swiip commented Jan 31, 2015

Sorry for the blackout, I wanted to focus on this :)

@Swiip
Copy link
Owner Author

Swiip commented Feb 3, 2015

Done, and with comments!

Coverage Status

@zckrs
Copy link
Collaborator

zckrs commented Feb 4, 2015

Awesome PR. 👏 👏 👏
Very nice work.

100% coverage 💃

Each contributor should read and complete the suite test before open a PR. https://github.com/Swiip/generator-gulp-angular/tree/refacto-format/test/node

@Swiip
Copy link
Owner Author

Swiip commented Feb 4, 2015

Thanks ;)

zckrs pushed a commit that referenced this pull request Feb 4, 2015
refacto index.js & format.js & add node tests
@zckrs zckrs merged commit b92231e into master Feb 4, 2015
@Swiip Swiip deleted the refacto-format branch September 9, 2015 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants