Put alt handling code in FormBase. Fixes #3584. #4380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoshiRulz
reviewed
Jul 10, 2025
|
|
||
| // Alt key hacks. We need this in order for hotkey bindings with alt to work. | ||
| /// <summary>sends a simulation of a plain alt key keystroke</summary> | ||
| internal void SendPlainAltKey(int lparam) |
There was a problem hiding this comment.
Why should they be more visible than they need to be?
There was a problem hiding this comment.
FormBase and the caller, Input, aren't semantically related.
There was a problem hiding this comment.
The caller is MainForm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also allows for the use of alt keys to use the menu items in Virtual Pad. Although for some reason I can't figure out, pressing alt does not underline the relevant letters in the tool bar like it does for other windows.
Note: If a hotkey is set to a key combination that normally would open a menu (e.g. Alt+F, which normally opens the File menu) then the hotkey is triggered and the menu is not opened. This is the same as prior behavior in MainForm, just now applied to tools as well.
Check if completed: