Possible fix for shell-quote problem #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I already tried that and it won't solve the problem in all cases. The best solution I came up so far is to write the whole JSON into a new file which will then be required. This also solves some HTML encoding problems. Only problem is that I have done this at an older version of this project and hadn't the time to port this over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to solve #33. By two regular expressions I try to get around the problem introduced by the behaviour of shell-quote for quote chars
"and exclamation marks!.There might be a better solution to this problem, but at least for my purposes this fix helps getting the job done. Both test cases work in this way.