fix(DatePicker): call onChange on Done button #2089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Collaborator
1 similar comment
Collaborator
Collaborator
1 similar comment
Collaborator
jsomsanith-tlnd
approved these changes
Apr 1, 2019
packages/components/src/DateTimePickers/DateTime/Manager/Manager.component.js
Outdated
Show resolved
Hide resolved
Collaborator
Collaborator
2 similar comments
Collaborator
Collaborator
sgangnant
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
In the
DatePicker, if the user don't change the date and click on the Done button, nothing happens.What is the chosen solution to this problem?
Always trigger
onChangeif user click on the Done button, even if the date has not been changed, in order to close theDatePicker.Please check if the PR fulfills these requirements
[ ] This PR introduces a breaking change