Skip to content

fix(query-core): shorten listeners code #7913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2024
Merged

fix(query-core): shorten listeners code #7913

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8c7fee
fix(query-core): shorten listeners code
manudeli Aug 18, 2024
32b815a
Merge branch 'main' into query-core/fix/shorten-listeners-code
manudeli Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/query-core/src/subscribable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
type Listener = () => void

export class Subscribable<TListener extends Function = Listener> {
Copy link
Collaborator Author

@manudeli manudeli Aug 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no case using default Listener of TListener in all tanstack/query's packages

protected listeners: Set<TListener>
export class Subscribable<TListener extends Function> {
protected listeners = new Set<TListener>()
Copy link
Collaborator Author

@manudeli manudeli Aug 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shorten listeners code


constructor() {
this.listeners = new Set()
this.subscribe = this.subscribe.bind(this)
}

Expand Down