fix: update error handling in MatchInner to access error data directly #4746
+123
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 0b6cccb
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-plugin
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-plugin
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-server
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
Signed-off-by: leesb971204 <[email protected]>
leesb971204
force-pushed
the
fix/nested-notFound-data
branch
from
04e715a to
f907711
Compare
leesb971204
changed the title
leesb971204
changed the title
Signed-off-by: leesb971204 <[email protected]>
leesb971204
commented
Jul 22, 2025
| return <router.options.defaultNotFoundComponent data={data} /> | ||
| return <router.options.defaultNotFoundComponent {...data} /> |
There was a problem hiding this comment.
This part causes the structure to become nested like data: { data: ... }.
| export type NotFoundRouteProps = { | ||
| // TODO: Make sure this is `| null | undefined` (this is for global not-founds) | ||
| data: unknown | ||
| } | ||
| export type NotFoundRouteProps = Partial<NotFoundError> |
There was a problem hiding this comment.
The props can contain not only data but also any value of type NotFoundError.
Since the global not found case passes undefined, we use Partial to account for the possibility that required fields might be added to NotFoundError in the future.
|
@schiller-manuel Is there anything else I should do to get a review on this? |
|
thanks for this PR!
|
brenelz
approved these changes
Aug 2, 2025
leesb971204
force-pushed
the
fix/nested-notFound-data
branch
from
28b5de3 to
a3bdffd
Compare
…s data Signed-off-by: leesb971204 <[email protected]>
…nent Signed-off-by: leesb971204 <[email protected]>
| @@ -240,7 +240,7 @@ export const Route = createFileRoute('/posts/$postId')({ | |||
| }) | |||
| return { post } | |||
| }, | |||
| // `data: unknown` is passed to the component via the `data` option when calling `notFound` | |||
| // `data: any` is passed to the component via the `data` option when calling `notFound` | |||
There was a problem hiding this comment.
why is this any instead of unknown?
There was a problem hiding this comment.
This is because the type of notFoundRouteProps was changed from unknown to Partial<NotFoundError>,
and the data in NotFoundError is currently typed as any.
There was a problem hiding this comment.
can we change it there to unknown? to force people to add some runtime type checks?
There was a problem hiding this comment.
do you mean it should be reverted the change?
There was a problem hiding this comment.
As I menthioned here, notFoundRouteProps can contain not only data but also any value of type NotFoundError like routeId.
or is it appropriate to convert the data type of NotFoundError to unknown?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4744