Update Makefile

[phillipj]

Checklist

• tests and code linting passes
• a test and/or benchmark is included
• documentation is changed or added
• the commit message follows commit guidelines

Affected core subsystem(s)

Description of change

[jbergstroem]

Looks good; a bit suspicious about the newline though.

[phillipj]

Is this really neccessary?

[phillipj]

Huh, I just enabled branch protection on master w/reviews required, which made this PR blocked due to @jbergstroem suggested change.

@jbergstroem what if I convinced you this newline makes a lot of sense... Are you able to remove the suggested change, making the PR mergeable again?

[jbergstroem]

Come to think of it - this will probably speed things up. Lets get it in!

[phillipj]

Strange, still blocked even tho my UI says

jbergstroem approved these changes an hour ago

[jbergstroem]

What's my user level? I need write perms

[jbergstroem]

(for review to be valid)

[jbergstroem]

It'd be nice if you could control the amount of required reviews!

[phillipj]

What's my user level? I need write perms

Have you accepted the org invite? I don't see you in the list of "people" in the org

[jbergstroem]

Obviously didn't.

[jbergstroem]

It'd be nice to see a minimum requirement to the amount of reviewers. Is this a setting somewhere?

[phillipj]

Agreed, AFAIK not possible tho. Fingers crossed it'll be added later

On Thursday, 15 September 2016, Johan Bergström [email protected]
wrote:

It'd be nice to see a minimum requirement to the amount of reviewers. Is
this a setting somewhere?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#16 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABLLE14b1AHbRBShp44qtiC83kbTOEFiks5qqUjJgaJpZM4IcXoX
.