Skip to content

Conversation

@tbui17
Copy link
Contributor

@tbui17 tbui17 commented Mar 8, 2025

fixes #1244

Changes

  • Removed Unix OS check in MockDirectory.Exists
  • Added additional tests for MockDirectory, MockDirectoryInfo, FileSystem.Directory

@tbui17 tbui17 force-pushed the fix-direxist-windows branch from a049751 to 377312f Compare March 9, 2025 08:00
@tbui17
Copy link
Contributor Author

tbui17 commented Mar 9, 2025

Not sure why SonarQube wouldn't detect the project for my PR specifically in contrast with all the other ones within the past couple weeks. Looking into how the GHA integration works now.

  Error: ERROR: Error during SonarScanner execution
  10:42:06 [ERR] ERROR: Error during SonarScanner execution
  Error: ERROR: Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator to check the permissions of the user the token belongs to
  10:42:06 [ERR] ERROR: Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator to check the permissions of the user the token belongs to
  Error: ERROR: 
  10:42:06 [ERR] ERROR: 
  Error: The SonarScanner did not complete successfully
  10:42:07 [ERR] The SonarScanner did not complete successfully
  Error: 10:42:07.076  Post-processing failed. Exit code: 1
  10:42:07 [ERR] 10:42:07.076  Post-processing failed. Exit code: 1
  Error: Target "CodeAnalysisEnd" has thrown an exception

…ont slash on Windows consistent with actual file system
@vbreuss vbreuss force-pushed the fix-direxist-windows branch from 377312f to 43c63b2 Compare March 12, 2025 11:58
@vbreuss
Copy link
Member

vbreuss commented Mar 13, 2025

Not sure why SonarQube wouldn't detect the project for my PR specifically in contrast with all the other ones within the past couple weeks. Looking into how the GHA integration works now.

  Error: ERROR: Error during SonarScanner execution
  10:42:06 [ERR] ERROR: Error during SonarScanner execution
  Error: ERROR: Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator to check the permissions of the user the token belongs to
  10:42:06 [ERR] ERROR: Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator to check the permissions of the user the token belongs to
  Error: ERROR: 
  10:42:06 [ERR] ERROR: 
  Error: The SonarScanner did not complete successfully
  10:42:07 [ERR] The SonarScanner did not complete successfully
  Error: 10:42:07.076  Post-processing failed. Exit code: 1
  10:42:07 [ERR] 10:42:07.076  Post-processing failed. Exit code: 1
  Error: Target "CodeAnalysisEnd" has thrown an exception

The issue seems to be a bit more complicated, as in Github Actions secrets are not provided to workflow runs from forks. I have to check how I can work around this limitation...

Update: For the time being I deactivated SonarCloud analysis on external PRs.

@vbreuss vbreuss changed the title fix(MockDirectory.Exists): Make MockDirectory.Exists behavior with front slash on Windows consistent with actual file system fix(MockDirectory.Exists): Make MockDirectory.Exists behavior with forward slash on Windows consistent with actual file system Mar 13, 2025
@vbreuss vbreuss changed the title fix(MockDirectory.Exists): Make MockDirectory.Exists behavior with forward slash on Windows consistent with actual file system fix: Make MockDirectory.Exists behavior with forward slash on Windows consistent with actual file system Mar 13, 2025
Copy link
Member

@vbreuss vbreuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks!

@vbreuss vbreuss enabled auto-merge (squash) March 13, 2025 19:58
@vbreuss vbreuss merged commit fe8f1db into TestableIO:main Mar 13, 2025
8 checks passed
@github-actions
Copy link

This is addressed in release v22.0.12.

@github-actions github-actions bot added the state: released Issues that are released label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state: released Issues that are released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MockFileSystem directory behavior with front slash inconsistent with actual file system behavior on Windows

2 participants