Skip to content

Add a naive recursive implementation of 0-1 Knapsack Problem #2743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 19, 2020
Merged

Add a naive recursive implementation of 0-1 Knapsack Problem #2743

merged 9 commits into from
Oct 19, 2020

Conversation

@tbsschroeder
Copy link
Contributor

@tbsschroeder tbsschroeder commented Oct 4, 2020

Describe your change:

Add a naive recursive implementation of 0-1 Knapsack Problem

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@poyea
Copy link
Member

poyea commented Oct 5, 2020

Did you take a look at dynamic_programming? Are there any existing implementation for this?

@tbsschroeder
Copy link
Contributor Author

tbsschroeder commented Oct 5, 2020

@poyea yes I did, also did this during a job interview, but I did not want to "overdo" the solution in the first place ;-)

@poyea
Copy link
Member

poyea commented Oct 16, 2020

I mean, this should go into dynamic_programming. Do you agree?

@tbsschroeder
Copy link
Contributor Author

tbsschroeder commented Oct 16, 2020

@poyea Sorry but no. This is a simple and recursive solution, the dynamic one looks different.

@poyea
Copy link
Member

poyea commented Oct 16, 2020

Yeah. It seems that a new folder might be the right place.

@poyea
Copy link
Member

poyea commented Oct 16, 2020

Would you mind adding a README.md in the folder? Just add something like this: https://en.wikipedia.org/wiki/Knapsack_problem

Example: https://github.com/TheAlgorithms/Python/tree/master/linear_algebra

@poyea poyea added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 16, 2020
@tbsschroeder
Copy link
Contributor Author

tbsschroeder commented Oct 16, 2020

@poyea added a Readme, also tests :-)

@TravisBuddy
Copy link

TravisBuddy commented Oct 16, 2020

Travis tests have failed

Hey @tbsschroeder,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 12034a30-0f83-11eb-8acb-27a1e4e1eb88

@TravisBuddy
Copy link

TravisBuddy commented Oct 16, 2020

Travis tests have failed

Hey @tbsschroeder,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: f0eaee00-0f84-11eb-8acb-27a1e4e1eb88

@tbsschroeder
Copy link
Contributor Author

tbsschroeder commented Oct 18, 2020

@poyea everything should be complete right now.

poyea
poyea approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@poyea poyea merged commit 802ac83 into TheAlgorithms:master Oct 19, 2020
@cozek cozek mentioned this pull request Nov 4, 2020
Closed
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@tbsschroeder @stokhos
Add a naive recursive implementation of 0-1 Knapsack Problem (TheAlgo…
f9e1bb1 
…rithms#2743)

* Add naive recursive implementation of 0-1 Knapsack problem

* Fix shadowing

* Add doctest

* Fix type hints

* Add link to wiki

* Blacked the file

* Fix isort

* Move knapsack / add readme and more tests

* Add missed main in tests
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@tbsschroeder @peRFectBeliever
Add a naive recursive implementation of 0-1 Knapsack Problem (TheAlgo…
03d480e 
…rithms#2743)

* Add naive recursive implementation of 0-1 Knapsack problem

* Fix shadowing

* Add doctest

* Fix type hints

* Add link to wiki

* Blacked the file

* Fix isort

* Move knapsack / add readme and more tests

* Add missed main in tests
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@tbsschroeder
Add a naive recursive implementation of 0-1 Knapsack Problem (TheAlgo…
5fb0a70 
…rithms#2743)

* Add naive recursive implementation of 0-1 Knapsack problem

* Fix shadowing

* Add doctest

* Fix type hints

* Add link to wiki

* Blacked the file

* Fix isort

* Move knapsack / add readme and more tests

* Add missed main in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poyea poyea poyea approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tbsschroeder @poyea @TravisBuddy