Skip to content

Add default arguments for Project Euler problem 6 #2957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2020
Merged

Add default arguments for Project Euler problem 6 #2957

merged 1 commit into from
Oct 7, 2020

Conversation

dhruvmanila
Copy link
Member

Continuing #2786

  • Add default arguments to solution functions
  • Add link to Project Euler problem 6
  • Add doctest for testing solution()
  • Removed test_solutions.py as it is redundant

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.

@dhruvmanila
Add default arguments for Project Euler problem 6
6bf0fbe 
- Add default arguments to solution function
- Add link to Project Euler problem 6
- Add doctest for testing `solution()`
- Removed test_solutions.py as it is redundant
@dhruvmanila dhruvmanila added the awaiting reviews This PR is ready to be reviewed label Oct 7, 2020
Kush1101
Kush1101 reviewed Oct 7, 2020
View reviewed changes
Copy link
Member

@Kush1101 Kush1101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kush1101 Kush1101 added hacktoberfest-accepted Accepted to be counted towards Hacktoberfest and removed awaiting reviews This PR is ready to be reviewed labels Oct 7, 2020
@Kush1101 Kush1101 merged commit ddf83ec into TheAlgorithms:master Oct 7, 2020
@dhruvmanila dhruvmanila deleted the patch-problem-06 branch October 7, 2020 05:00
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@dhruvmanila @stokhos
Add default arguments for Project Euler problem 6 (TheAlgorithms#2957)
273cc2e 
- Add default arguments to solution function
- Add link to Project Euler problem 6
- Add doctest for testing `solution()`
- Removed test_solutions.py as it is redundant
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@dhruvmanila
Add default arguments for Project Euler problem 6 (TheAlgorithms#2957)
5b0a113 
- Add default arguments to solution function
- Add link to Project Euler problem 6
- Add doctest for testing `solution()`
- Removed test_solutions.py as it is redundant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kush1101 Kush1101 Kush1101 approved these changes

@realDuYuanChao realDuYuanChao Awaiting requested review from realDuYuanChao

Assignees

No one assigned

Labels

hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhruvmanila @Kush1101