Skip to content

Add type hints and default args for Project Euler problem 5 #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2020
Merged

Add type hints and default args for Project Euler problem 5 #2982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7669937
add type hints and default args for problem 5
sgalpha01 Oct 7, 2020
db6d703
Update sol1.py
dhruvmanila Oct 8, 2020
a7a8ae6
Update sol2.py
dhruvmanila Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project_euler/problem_05/sol1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"""


def solution(n):
def solution(n: int = 20) -> int:
"""Returns the smallest positive number that is evenly divisible(divisible
with no remainder) by all of the numbers from 1 to n.

Expand Down
6 changes: 3 additions & 3 deletions project_euler/problem_05/sol2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,18 @@
""" Euclidean GCD Algorithm """


def gcd(x, y):
def gcd(x: int, y: int) -> int:
return x if y == 0 else gcd(y, x % y)


""" Using the property lcm*gcd of two numbers = product of them """


def lcm(x, y):
def lcm(x: int, y: int) -> int:
return (x * y) // gcd(x, y)


def solution(n):
def solution(n: int = 20) -> int:
"""Returns the smallest positive number that is evenly divisible(divisible
with no remainder) by all of the numbers from 1 to n.

Expand Down