Add Lattice impl for Antichain #259
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation of
Lattice
for timely'sAntichain
type. We are unable to add one forAntichainRef
as we cannot produceSelf
types for it without borrowed data. Perhaps a more exotic implementation would unify this stuff, but for the moment just trying out this limited form.The
Timestamp
trait is removed fromLattice
. It existed in order to inherit theminimum()
method, thoughLattice
itself does not require this. This could break some external code, but the change was relatively recent (post 0.11, I believe).The PR only introduces the implementation, and does not tidy anything in the code yet. There should probably be a few passes of that, and potentially conversion of some
Vec<T>
types intoAntichain<T>
types where it is known that they should be such (e.g. probably inDescription
?).Note: this will be broken until TimelyDataflow/timely-dataflow#322 lands in the timely repo.
cc @LorenzSelv