Skip to content

Conversation

elindsey
Copy link
Contributor

@elindsey elindsey commented Nov 9, 2020

I'm naming the logging dataflows in materialize and keep writing boilerplate like

    let worker_logging = worker.log_register().get("timely");
    let traces = worker.dataflow_core(
        "Dataflow: differential logging",
        worker_logging,
        Box::new(()),
        move |_, scope| {});

Which could instead be

let traces = worker.dataflow_named("Dataflow: differential logging", move |scope| {});

Copy link
Member

@frankmcsherry frankmcsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a great idea, thanks!

@elindsey
Copy link
Contributor Author

When convenient, could I get a merge? 🙂

@frankmcsherry frankmcsherry merged commit a025087 into TimelyDataflow:master Nov 10, 2020
@elindsey elindsey deleted the dataflow_named branch November 10, 2020 15:39
@github-actions github-actions bot mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants