Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions timely/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ timely_bytes = { path = "../bytes", version = "0.11" }
timely_logging = { path = "../logging", version = "0.11" }
timely_communication = { path = "../communication", version = "0.11" }
crossbeam-channel = "0.5.0"
futures-util = "0.3"

[dev-dependencies]
timely_sort="0.1.6"
Expand Down
10 changes: 7 additions & 3 deletions timely/src/dataflow/operators/capability.rs
Original file line number Diff line number Diff line change
Expand Up @@ -371,10 +371,14 @@ impl<T: Timestamp> CapabilitySet<T> {
/// Downgrades the set of capabilities to correspond with the times in `frontier`.
///
/// This method panics if any element of `frontier` is not greater or equal to some element of `self.elements`.
pub fn downgrade(&mut self, frontier: &[T]) {
pub fn downgrade<B, F>(&mut self, frontier: F)
where
B: std::borrow::Borrow<T>,
F: IntoIterator<Item=B>,
Comment on lines +376 to +377
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but can this be

F: IntoIterator,
F::Item: std::borrow::Borrow<T>,

or is the generic argument B necessary / helpful?

{
let count = self.elements.len();
for time in frontier.iter() {
let capability = self.delayed(time);
for time in frontier.into_iter() {
let capability = self.delayed(time.borrow());
self.elements.push(capability);
}
self.elements.drain(..count);
Expand Down
2 changes: 1 addition & 1 deletion timely/src/dataflow/operators/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ pub use self::delay::Delay;
pub use self::exchange::Exchange;
pub use self::broadcast::Broadcast;
pub use self::probe::Probe;
pub use self::to_stream::ToStream;
pub use self::to_stream::{ToStream, ToStreamAsync, Event};
pub use self::capture::Capture;
pub use self::branch::{Branch, BranchWhen};
pub use self::ok_err::OkErr;
Expand Down
89 changes: 86 additions & 3 deletions timely/src/dataflow/operators/to_stream.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
//! Conversion to the `Stream` type from iterators.

use crate::progress::Timestamp;
use std::pin::Pin;
use std::sync::Arc;
use std::task::{Context, Poll};

use crate::Data;
use crate::dataflow::channels::Message;
use crate::dataflow::operators::generic::operator::source;
use crate::dataflow::{Stream, Scope};
use crate::dataflow::operators::CapabilitySet;
use crate::dataflow::{Scope, Stream};
use crate::progress::Timestamp;
use crate::Data;

/// Converts to a timely `Stream`.
pub trait ToStream<T: Timestamp, D: Data> {
Expand Down Expand Up @@ -56,3 +60,82 @@ impl<T: Timestamp, I: IntoIterator+'static> ToStream<T, I::Item> for I where I::
})
}
}

/// Data and progress events of the native stream.
pub enum Event<F: IntoIterator, D> {
/// Indicates that timestamps have advanced to frontier F
Progress(F),
/// Indicates that event D happened at time T
Message(F::Item, D),
}

/// Converts to a timely `Stream`.
pub trait ToStreamAsync<T: Timestamp, D: Data> {
/// Converts a [native `Stream`](futures_util::stream::Stream) of [`Event`s](Event) into a [timely
/// `Stream`](crate::dataflow::Stream).
///
/// # Examples
///
/// ```
/// use futures_util::stream;
///
/// use timely::dataflow::operators::{Capture, Event, ToStream, ToStreamAsync};
/// use timely::dataflow::operators::capture::Extract;
///
/// let native_stream = stream::iter(vec![
/// Event::Message(0, 0),
/// Event::Message(0, 1),
/// Event::Message(0, 2),
/// Event::Progress(Some(0)),
/// ]);
///
/// let native_stream = Box::pin(native_stream);
///
/// let (data1, data2) = timely::example(|scope| {
/// let data1 = native_stream.to_stream(scope).capture();
/// let data2 = vec![0,1,2].to_stream(scope).capture();
///
/// (data1, data2)
/// });
///
/// assert_eq!(data1.extract(), data2.extract());
/// ```
fn to_stream<S: Scope<Timestamp = T>>(self: Pin<Box<Self>>, scope: &S) -> Stream<S, D>;
}

impl<T, D, F, I> ToStreamAsync<T, D> for I
where
D: Data,
T: Timestamp,
F: IntoIterator<Item = T>,
I: futures_util::stream::Stream<Item = Event<F, D>> + ?Sized + 'static,
{
fn to_stream<S: Scope<Timestamp = T>>(mut self: Pin<Box<Self>>, scope: &S) -> Stream<S, D> {
source(scope, "ToStreamAsync", move |capability, info| {
let activator = Arc::new(scope.sync_activator_for(&info.address[..]));

let mut cap_set = CapabilitySet::from_elem(capability);

move |output| {
let waker = futures_util::task::waker_ref(&activator);
let mut context = Context::from_waker(&waker);

// Consume all the ready items of the source_stream and issue them to the operator
while let Poll::Ready(item) = self.as_mut().poll_next(&mut context) {
match item {
Some(Event::Progress(time)) => {
cap_set.downgrade(time);
}
Some(Event::Message(time, data)) => {
output.session(&cap_set.delayed(&time)).give(data);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but this will eventually have throughput issues. At least, timely can send data around much faster than it can mint capabilities. It may eventually be smart to have the D of the enum implement IntoIterator<Item = D2>, though perhaps .. that is just a flatmap after this. Idk. Doesn't block anything here, but wanted to call out!

}
None => {
cap_set.downgrade(&[]);
break;
}
}
}
}
})
}
}
8 changes: 8 additions & 0 deletions timely/src/scheduling/activate.rs
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
//! Parking and unparking timely fibers.

use std::rc::Rc;
use std::sync::Arc;
use std::cell::RefCell;
use std::thread::Thread;
use std::collections::BinaryHeap;
use std::time::{Duration, Instant};
use std::cmp::Reverse;
use crossbeam_channel::{Sender, Receiver};
use futures_util::task::ArcWake;

/// Methods required to act as a timely scheduler.
///
Expand Down Expand Up @@ -268,6 +270,12 @@ impl SyncActivator {
}
}

impl ArcWake for SyncActivator {
fn wake_by_ref(arc_self: &Arc<Self>) {
arc_self.activate().unwrap();
}
}

/// The error returned when activation fails across thread boundaries because
/// the receiving end has hung up.
#[derive(Debug)]
Expand Down