Skip to content

Conversation

Kixiron
Copy link
Contributor

@Kixiron Kixiron commented Feb 17, 2021

  • Implemented Debug for Stream (and will implement Debug for Arranged and Collection after this lands), this allows for unwrapping on items that hold streams, as an example Vec<Stream>::try_into().unwrap() would previously error and force you to use .unwrap_or_else(|_| panic!()), this allows it to happen seamlessly. Just a nice little quality of life tweak
  • Fixed a few clippy lints, there seems to be quite a lot so if it's ok with you I can make a follow-up that fixes more of them

@frankmcsherry
Copy link
Member

Thanks! Just to nip things in the bud, clippy and I disagree a lot! Lemme take a look before you sink too much time, as several classes of its lints are imo antipatterns. Some are great, but .. not all. :)

@Kixiron
Copy link
Contributor Author

Kixiron commented Mar 8, 2021

Any updates on this?

@frankmcsherry
Copy link
Member

Yes, as we discussed on the community Slack, the clippy lint fixes are going to hold up the PR. If you'd like to go for just the Debug implementation that is great! And, if at all possible minimum cargo fmt line noise.

@Kixiron
Copy link
Contributor Author

Kixiron commented Mar 8, 2021

Sure, can do!

@frankmcsherry
Copy link
Member

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants