Skip to content

Reduce the amount of cloning in reachability.rs #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Reduce the amount of cloning in reachability.rs #374

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c68c768
reduce the amount of cloning
frankmcsherry Mar 25, 2021
85f5429
re-introduce derived Clone
frankmcsherry Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions timely/src/progress/reachability.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ impl<T: Timestamp> Builder<T> {
/// This method has the opportunity to perform some error checking that the path summaries
/// are valid, including references to undefined nodes and ports, as well as self-loops with
/// default summaries (a serious liveness issue).
pub fn build(&self) -> (Tracker<T>, Vec<Vec<Antichain<T::Summary>>>) {
pub fn build(self) -> (Tracker<T>, Vec<Vec<Antichain<T::Summary>>>) {

if !self.is_acyclic() {
println!("Cycle detected without timestamp increment");
Expand Down Expand Up @@ -483,7 +483,7 @@ impl<T:Timestamp> Tracker<T> {
///
/// The result is a pair of tracker, and the summaries from each input port to each
/// output port.
pub fn allocate_from(builder: &Builder<T>) -> (Self, Vec<Vec<Antichain<T::Summary>>>) {
pub fn allocate_from(builder: Builder<T>) -> (Self, Vec<Vec<Antichain<T::Summary>>>) {

// Allocate buffer space for each input and input port.
let mut per_operator =
Expand Down Expand Up @@ -526,8 +526,8 @@ impl<T:Timestamp> Tracker<T> {

let tracker =
Tracker {
nodes: builder.nodes.clone(),
edges: builder.edges.clone(),
nodes: builder.nodes,
edges: builder.edges,
per_operator,
target_changes: ChangeBatch::new(),
source_changes: ChangeBatch::new(),
Expand Down