exchange: De-duplicate partitioning logic #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the partitioning logic has two separate branches for power-of-two peers using bit masking and mod for all other configurations. The branches duplicate the logic to distribute the data to the pushers. This change moves the common functionality into a separate function. We force inlining of the partition function to avoid a performance penalty. Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
commented
Dec 8, 2021
|
|
||
| /// Partition data according to an index function | ||
| #[inline(always)] | ||
| fn partition<F: Fn(u64) -> usize>(&mut self, time: &T, data: &mut Vec<D>, func: F) { |
There was a problem hiding this comment.
Rename to push_partitioned and fix the doc comment.
Rename, and redocument.
|
Looks great with naming nit fixed; thanks very much! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the partitioning logic has two separate branches for
power-of-two peers using bit masking and mod for all other configurations.
The branches duplicate the logic to distribute the data to the pushers.
This change moves the common functionality into a separate function.
We force inlining of the partition function to avoid a performance penalty.
Signed-off-by: Moritz Hoffmann [email protected]