Push filter to upstream operator #439
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixiron
reviewed
Dec 2, 2021
| let mut input = builder.new_input_filter(self, Pipeline, vec![], move |data, buffer| { | ||
| match data { | ||
| RefOrMut::Ref(data) => { | ||
| buffer.extend(data.into_iter().filter(|x| predicate(*x)).cloned()) |
There was a problem hiding this comment.
Fairly unrelated, but it'd be nice if operators could pass on references instead of requiring cloning, that could remove a lot of fairly redundant clones
There was a problem hiding this comment.
This might do what you suggested: #471
3 tasks
Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
force-pushed
the
input_filter
branch
from
ddc5599 to
c900a18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow operators to push filter expressions to the upstream
Tee.This can reduce the amount of data copied within tees, but care needs to be taken to ensure the progress tracking invariants.
The intention is not to land this change but rather have a discussion if this is the right direction for such a change. I don't think the progress tracking wiring is particularly elegant, but seems to do the job. Maybe we could find a better abstraction here. This PR also breaks a public interface, the
Stream::connect_tofunction. I'm not sure if there are any users outside of Timely that call this function.