Skip to content

Conversation

@antiguru
Copy link
Member

@antiguru antiguru commented Mar 17, 2023

Warning: breaking changes up ahead!

Fixes #510

This change removes the Core variants of types, traits, and functions that we introduced in #426. However, this means it introduces breaking changes, specifically where we used Data parameters in the past we now use Container. This is desirable because maintaining the old facade comes with a cognitive overhead. After this change, most places that previously specified individual elements now specify containers. All places that only apply to specific (mostly Vec<_>) containers are exepted.

The most notable breaking changes are in inputs, to_stream, and feedback, which now need to know the kind of container they produce. In the past, they were fixed to Vec<_>, but now the caller needs to be explicit about it.

The PR looks rather large, but most of the changes are purely mechanical. For wildly-used types, there is a commit that inlines the non-core variant, and a follow-up to rename the core-variant to the old name. This should make it explicit that each change has limited scope. Tests should pass after each individual change.

  • 60ae900 changes inputs to containers.
  • 5987d4c changes feedback to use containers.

antiguru added 30 commits March 16, 2023 20:15
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru antiguru requested a review from frankmcsherry March 17, 2023 02:02
antiguru added a commit to antiguru/differential-dataflow that referenced this pull request Mar 17, 2023
@antiguru
Copy link
Member Author

TimelyDataflow/differential-dataflow#383 shows what changes we'd need to make in Differential to switch to the new interface.

@antiguru
Copy link
Member Author

Superseded by various other changes.

@antiguru antiguru closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Core variants of various types

1 participant