Skip to content

Conversation

antiguru
Copy link
Member

@antiguru antiguru commented Jun 4, 2023

This changes activation to avoid an associated event, which is currently not used anymore. It also switches to a Vec to contain the activations, and deduplicates before activating operators.

This improves performance in edge cases:

➜  timely-dataflow git:(activation_no_event) time taskset 1 target/release/examples/pingpong $((2**20)) 64
taskset 1 target/release/examples/pingpong $((2**20)) 64  3.63s user 0.00s system 99% cpu 3.638 total
➜  timely-dataflow-master git:(master) time taskset 1 target/release/examples/pingpong $((2**20)) 64
taskset 1 target/release/examples/pingpong $((2**20)) 64  3.32s user 0.78s system 99% cpu 4.106 total

use std::collections::VecDeque;

use crate::{Push, Pull};
use crate::allocator::Event;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if Event still needs to exist.

borrow.sort_unstable();
borrow.dedup();
for channel in borrow.drain(..) {
// TODO: Pay more attent to `_event`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update comment.

Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru antiguru force-pushed the activation_no_event branch from 2231deb to 34f287d Compare February 5, 2024 21:18
Signed-off-by: Moritz Hoffmann <[email protected]>
Copy link
Member

@frankmcsherry frankmcsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, and we've left the comment in that reminds us how it might be different in the future (tracking the emptiness of channels, and not scheduling only on the basis of a message both sent and received).

@frankmcsherry frankmcsherry merged commit b869dcb into TimelyDataflow:master Feb 5, 2024
@github-actions github-actions bot mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants